move ir node defs into subpackage of ir #14783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
from
005d23f to
52033ec
Compare
patrick-schultz
force-pushed
the
ps/ir-defs
branch
2 times, most recently
from
520608e to
9c1ca69
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
from
52033ec to
2d1ab3b
Compare
patrick-schultz
force-pushed
the
ps/ir-defs
branch
from
9c1ca69 to
d7d876a
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
2 times, most recently
from
17b9cdd to
b64f011
Compare
patrick-schultz
force-pushed
the
ps/ir-defs
branch
from
d7d876a to
1666c51
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
from
b64f011 to
b4c7447
Compare
patrick-schultz
force-pushed
the
ps/ir-defs
branch
from
1666c51 to
5612da7
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
from
b4c7447 to
93620ef
Compare
patrick-schultz
force-pushed
the
ps/ir-defs
branch
from
5612da7 to
753c072
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
from
93620ef to
e0b9c06
Compare
patrick-schultz
force-pushed
the
ps/ir-defs
branch
2 times, most recently
from
006a931 to
14a2222
Compare
patrick-schultz
force-pushed
the
ps-12-17-move_mill_modules_into_subdirectory
branch
3 times, most recently
from
fcb6c23 to
b9fe4aa
Compare
patrick-schultz
force-pushed
the
ps/ir-defs
branch
from
14a2222 to
472ee66
Compare
Base automatically changed from
ps-12-17-move_mill_modules_into_subdirectory
to
main
January 24, 2025 20:33
patrick-schultz
force-pushed
the
ps/ir-defs
branch
from
472ee66 to
7608152
Compare
ehigham
approved these changes
Jan 28, 2025
chrisvittal
approved these changes
Jan 28, 2025
| sealed trait TypedIR[T <: Type] extends IR { | ||
| override def typ: T = tcoerce[T](super.typ) | ||
| } | ||
| package defs { |
There was a problem hiding this comment.
I guess I still don't understand scala style. Why have an inline package like this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Move the definitions of the IR nodes from package
irinto a subpackageir.defs. I originally did this to prepare for codegenerating the node definitions. While I don't think it was necessary in the end, I still think this is a beneficial change, as theirpackage has become a big pile of different functionality, and it would be good to start breaking it up.Security Assessment
Impact Description
Non-functional change, only changes the java package paths of some classes.
(Reviewers: please confirm the security impact before approving)