-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] move mill modules into subdirectory #14772
[query] move mill modules into subdirectory #14772
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8c5873b
to
30ca0f4
Compare
ab6e982
to
f7dac2a
Compare
30ca0f4
to
8d105cf
Compare
f7dac2a
to
6c275c2
Compare
hail/build.mill
Outdated
@@ -126,6 +127,8 @@ trait HailScalaModule extends SbtModule with ScalafmtModule with ScalafixModule | |||
|
|||
object `package` extends RootModule with HailScalaModule { outer => | |||
|
|||
override def millSourcePath: Path = super.millSourcePath / "modules" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an opportunity for hail/hail/hail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an actual request to change the name? I don't have any strong feelings one way or the other.
8d105cf
to
2b10d49
Compare
6c275c2
to
c291b9c
Compare
2b10d49
to
d35b0d5
Compare
c291b9c
to
1147b2b
Compare
d35b0d5
to
2b10d49
Compare
1147b2b
to
c291b9c
Compare
2b10d49
to
c61d0a8
Compare
c291b9c
to
51abd7d
Compare
51abd7d
to
2b3a4af
Compare
2b3a4af
to
a459164
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as we're already moving everything, should I also switch to the mill default directory structure, moving modules/src/main/java
and modules/src/main/scala
to modules/src
, moving modules/src/main/resources
to modules/resources
, and moving modules/src/test
to modules/test
?
If that's the mill default project structure, then yes. |
a459164
to
a40fa7d
Compare
47f75a5
to
e7d3284
Compare
c54210d
to
e2bdc83
Compare
56b0aa4
to
733247e
Compare
c2603da
to
005d23f
Compare
733247e
to
f9ed5ef
Compare
005d23f
to
52033ec
Compare
f9ed5ef
to
ffb5e4e
Compare
52033ec
to
2d1ab3b
Compare
b64f011
to
b4c7447
Compare
468844b
to
fcb6c23
Compare
fcb6c23
to
b9fe4aa
Compare
Change Description
To prepare for breaking the mill build up into more smaller modules, move all mill modules into a subdirectory, so as to not pollute
hail/hail
with a bunch of module directories.Only 6 files are actually modified, the rest are just moved:
The moves were performed by
Security Assessment
Impact Description
Low-level refactoring of the build system and source directory structure
(Reviewers: please confirm the security impact before approving)