Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev processes] Fixup gsa-key copying instructions, add debug line to rotate_keys.py #14735

Merged
merged 1 commit into from
Oct 24, 2024
Merged

[Dev processes] Fixup gsa-key copying instructions, add debug line to rotate_keys.py #14735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev-docs/development-process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ The service accounts used in developer namespaces do not have permission to crea
to run real jobs on the developer namespaces' batch services:
```bash
$ download-secret <username>-gsa-key
$ mv secret.json key.json
$ kubectl create secret generic <username>-gsa-key --namespace=<username> --from-file=key.json
$ kubectl create secret generic <username>-gsa-key --namespace=<username> --from-file=contents/key.json
$ cd - # Return to your original directory
```

To submit jobs to your dev namespace, you need to configure your local hail
Expand Down
2 changes: 2 additions & 0 deletions devbin/rotate_keys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ def service_account_email(self):
return self.key_data['client_email']

def private_key_id(self):
if not 'private_key_id' in self.key_data:
raise ValueError(f'No private_key_id field found for {self} in {self.key_data}.')
return self.key_data['private_key_id']

def matches_iam_key(self, k: 'IAMKey'):
Expand Down