Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev processes] Fixup gsa-key copying instructions, add debug line to rotate_keys.py #14735

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

cjllanwarne
Copy link
Collaborator

Change Description

Corrects our gsa-key copying instructions (from #14664) to copy the key contents, not the entire secret metadata.

The batch service seems resilient to these badly formed secrets, but the rotate_keys.py script was not.

Security Assessment

Delete all except the correct answer:

  • This change has a low security impact

Impact Description

  • Not a production change
  • Does not add any new information to the secrets, only formats them a useable way.
  • Only in dev namespaces

(Reviewers: please confirm the security impact before approving)

Copy link
Collaborator

@patrick-schultz patrick-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris!

Copy link
Collaborator

@chrisvittal chrisvittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Chris!

@hail-ci-robot hail-ci-robot merged commit 21684e7 into hail-is:main Oct 24, 2024
2 of 3 checks passed
@cjllanwarne cjllanwarne deleted the cjl_key_rotation_fixup branch October 24, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants