merge-queue: embarking main (f012bfa) and #426 together #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
This is a placeholder, pending a discussion around how to display and log errors.
NB this is an internal error condition which should never actually occur.
This replaces the previous hardcoded trees. Note that we don't yet display a definition's name or type. These will be added in due course, once we've made some design decisions about how to lay out multiple trees. We also currently require that the session contains precisely one editable module, throwing errors otherwise. We will some day relax this decision, once UX issues have been worked out.
With the previous style, further indentation was needed for each new check. Instead, we now utilise early returns to keep a flatter tree.
|
The pull request #426 is mergeable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 This combination of pull requests has been checked successfully 🎉
Branch main (f012bfa) and #426 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #426.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:base=maincheck-success="build-frontend"check-success="buildkite/primer-app/pr/required-nix-ci"check-success="deploy-to-chromatic"More informations about Mergify merge queue can be found in the documentation.
Mergify commands
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the queue rulesAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com