Render a module from the database #426
Conversation
This is a placeholder, pending a discussion around how to display and log errors.
NB this is an internal error condition which should never actually occur.
| } | ||
| // This hook is *technically* conditional. | ||
| // But if the condition above fails, then the app is broken anyway. | ||
| // eslint-disable-next-line react-hooks/rules-of-hooks |
There was a problem hiding this comment.
Bit annoying. Not sure there's a better way.
|
|
||
| export const Error = (p: ErrorProps): JSX.Element => ( | ||
| <p className="mx-4">Error: {p.string}</p> | ||
| ); |
There was a problem hiding this comment.
We need to think about error handling (hackworthltd/primer#237). Until then, at least if we consistently use this component, we've got a single source of information to keep track of what needs cleaning up on the frontend.
| if (editableModules.length > 1) { | ||
| return ( | ||
| <Error | ||
| string={"Multiple editable modules: " + JSON.stringify(editableModules)} |
There was a problem hiding this comment.
Maybe we should just log a warning here, rather than erroring.
Longer term, we need to think about a frontend equivalent of hackworthltd/primer#179.
packages/primer-app/src/App.tsx
Outdated
| return ( | ||
| <Error | ||
| string={ | ||
| "Multiple editable modules: " + JSON.stringify(editableModules) |
There was a problem hiding this comment.
It's probably a good idea to mention in the commit message that we don't handle multiple editable modules yet.
There was a problem hiding this comment.
If it's not too late (I know that editing commit messages is a pain), maybe also mention that we don't yet render types, only terms.
|
Thanks. I have one request above, and then (per discussion in chat) we should document the issues with |
This replaces the previous hardcoded trees. Note that we don't yet display a definition's name or type. These will be added in due course, once we've made some design decisions about how to lay out multiple trees. We also currently require that the session contains precisely one editable module, throwing errors otherwise. We will some day relax this decision, once UX issues have been worked out.
With the previous style, further indentation was needed for each new check. Instead, we now utilise early returns to keep a flatter tree.
georgefst
force-pushed
the
georgefst/non-hardcoded-session-tree
branch
from
76430c1 to
cdbcb4a
Compare
|
This work has revealed that
|
No description provided.