Check if addClass is truthy before adding it to element #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOMTokenList::add() throws a DOMException if you try to add an empty string as a class. This check prevents this from happening so that you can set ValidationInputValidCssClassName etc. to an empty string if you don't want to add classes for valid input fields or messages for instance.
haacked
reviewed
Nov 2, 2023
| @@ -1254,7 +1254,7 @@ export class ValidationService { | |||
| * @param removeClass Class to remove | |||
| */ | |||
| private swapClasses(element: Element, addClass: string, removeClass: string) { | |||
| if (!element.classList.contains(addClass)) { | |||
| if (addClass && !element.classList.contains(addClass)) { | |||
| element.classList.add(addClass); | |||
| } | |||
| if (element.classList.contains(removeClass)) { | |||
There was a problem hiding this comment.
Does this throw if removeClass is blank? I wonder if we should protect against that too.
There was a problem hiding this comment.
Yes, it throws if you call element.classList.remove('') but the contains(removeClass) check prevents that from happening so I didn't add it for that case.
There was a problem hiding this comment.
Ah, makes sense. Thanks for following up and the contribution!
haacked
approved these changes
Nov 2, 2023
|
This is now live on NPM https://www.npmjs.com/package/aspnet-client-validation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOMTokenList::add() throws a DOMException if you try to add an empty string as a class. This check prevents this from happening so that you can set ValidationInputValidCssClassName etc. to an empty string if you don't want to add classes for valid input fields or messages for instance.