Merge pull request #81 from davidkarlsson/fix-add-class-error

haacked · web-flow · commit 2430929b181b · 2023-11-02T09:13:36.000-07:00
Check if addClass is truthy before adding it to element
diff --git a/src/index.ts b/src/index.ts
@@ -1256,7 +1256,7 @@ export class ValidationService {
      * @param removeClass Class to remove
      */
     private swapClasses(element: Element, addClass: string, removeClass: string) {
-        if (!element.classList.contains(addClass)) {
+        if (addClass && !element.classList.contains(addClass)) {
             element.classList.add(addClass);
         }
         if (element.classList.contains(removeClass)) {

Original file line number	Diff line number	Diff line change
`@@ -1256,7 +1256,7 @@ export class ValidationService {`
`1256`	`1256`	`* @param removeClass Class to remove`
`1257`	`1257`	`*/`
`1258`	`1258`	`private swapClasses(element: Element, addClass: string, removeClass: string) {`
`1259`		`- if (!element.classList.contains(addClass)) {`
	`1259`	`+ if (addClass && !element.classList.contains(addClass)) {`
`1260`	`1260`	`element.classList.add(addClass);`
`1261`	`1261`	`}`
`1262`	`1262`	`if (element.classList.contains(removeClass)) {`