Remove duplicate validation summary entries #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #56 (and #1053 in Umbraco Forms).
This issue was the rendering of multiple, identical messages for required checkbox or radio button lists - with the PR in place we now only have one per fieldset:
I've done this will two extra checks in rendering the summary bullet points:
I also fixed up an issue found in testing this along with a previous update, which was that in these cases where we add or remove an error from other inputs with the same name, we weren't updating the cached
this.summary
value for all inputs. This caused the summary to not render sometimes as it was considered unchanged.To test this you should be able to look at the "Checkboxes" demo which I've updated to include a radio button list too, as well as a validation summary element.