Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation summary renders a message for each of the field (3 fields - 3 different validation message) #1053

Closed
sergiutesu opened this issue Jul 24, 2023 · 3 comments
Labels
release/8.13.10 release/10.5.0 release/12.1.0 state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks

Comments

@sergiutesu
Copy link

sergiutesu commented Jul 24, 2023

Umbraco Forms version: 10.4.0

When enabling the "Show validation summary" option you will get a validation message for each field you have rather than a single message. If you have 4 fields you'll get 4 messages. See video:

image

chrome_J4JkAOTgRB.mp4

The problem seems to be somewhere in the ASPNET client validation: https://github.com/haacked/aspnet-client-validation

Steps to reproduce

  • Create a simple form with both single and multiple-choice types.
  • Set the fields as mandatory
  • Make sure to enable the "Show validation summary"
  • Render your form
  • Try to submit only one of the mandatory fields without selecting anything on the other one
  • You'll see the error

Expected result

You only get one validation message not one for each field

Actual result

You get several messages for each field you have in your form


This item has been added to our backlog AB#31464

@AndyButland
Copy link

Thanks @sergiutesu - as discussed, and just for the record here, it looks like this issue lies in the client-side validation library we are using. I'm going to see if we can resolve it there and submit a PR which, if accepted and included in a new release, we can take a reference on to resolve this for future Forms releases.

@AndyButland
Copy link

PR for the client-side validation library has been created here.

@AndyButland
Copy link

The upstream library has been updated now, and we'll take a dependency on version 0.8.13 for the next releases that will include this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/8.13.10 release/10.5.0 release/12.1.0 state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks
Projects
None yet
Development

No branches or pull requests

2 participants