Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix removing validation + Undebounce #110

Merged
merged 18 commits into from
May 6, 2024
Merged

Fix removing validation + Undebounce #110

merged 18 commits into from
May 6, 2024
+339 −225

Commits on Mar 30, 2024

  1. Enable validation for demo index

    @dahlbyk
    dahlbyk committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    6b57a3b View commit details
    Browse the repository at this point in the history

  2. Add toggle to remove/re-scan a form

    @dahlbyk
    dahlbyk committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    d6ae908 View commit details
    Browse the repository at this point in the history

  3. Guard against deleted validator

    @dahlbyk
    dahlbyk committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    8ec9028 View commit details
    Browse the repository at this point in the history

  4. Simplify adding validate event listener

    @dahlbyk
    dahlbyk committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    43ea6cf View commit details
    Browse the repository at this point in the history

  5. Remove input event listeners

    @dahlbyk
    dahlbyk committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    cecbc8b View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. Remove form event listeners

    @dahlbyk
    dahlbyk committed May 4, 2024
    Configuration menu
    Copy the full SHA
    1938d05 View commit details
    Browse the repository at this point in the history

  2. Refactor private scans to use callback

    @dahlbyk
    dahlbyk committed May 4, 2024
    Configuration menu
    Copy the full SHA
    f083dcf View commit details
    Browse the repository at this point in the history

  3. Allow scan/remove/watch without root

    @dahlbyk
    dahlbyk committed May 4, 2024
    Configuration menu
    Copy the full SHA
    c83f25a View commit details
    Browse the repository at this point in the history

  4. Store messages per form

    @dahlbyk
    dahlbyk committed May 4, 2024
    Configuration menu
    Copy the full SHA
    7edae2d View commit details
    Browse the repository at this point in the history

  5. Untrack form messages

    @dahlbyk
    dahlbyk committed May 4, 2024
    Configuration menu
    Copy the full SHA
    d8fa06e View commit details
    Browse the repository at this point in the history

  6. Remove validatable assumption

    @dahlbyk
    dahlbyk committed May 4, 2024
    Configuration menu
    Copy the full SHA
    d51a62c View commit details
    Browse the repository at this point in the history

  7. Simplify resetField; clear message class, too

    @dahlbyk
    dahlbyk committed May 4, 2024
    Configuration menu
    Copy the full SHA
    385a3cf View commit details
    Browse the repository at this point in the history

  8. Only debounce validation on input event 

    Manual validation is no longer debounced:
- validateField()
- isFieldValid()
- validateForm()
    @dahlbyk
    dahlbyk committed May 4, 2024
    Configuration menu
    Copy the full SHA
    5b7d89b View commit details
    Browse the repository at this point in the history

  9. Capture validation task

    @dahlbyk
    dahlbyk committed May 4, 2024
    Configuration menu
    Copy the full SHA
    ac14f19 View commit details
    Browse the repository at this point in the history

  10. Refactor to async/await

    @dahlbyk
    dahlbyk committed May 4, 2024
    Configuration menu
    Copy the full SHA
    c838a40 View commit details
    Browse the repository at this point in the history

  11. Return promise from validateForm() and validateField() 

    These have returned void, so it's not a breaking change.

isFieldValid() returns boolean; changing that to Promise<boolean> would
be a breaking change, so it's left as-is for now.
    @dahlbyk
    dahlbyk committed May 4, 2024
    Configuration menu
    Copy the full SHA
    ab68138 View commit details
    Browse the repository at this point in the history

  12. Consistent usage of this.formInputs

    @dahlbyk
    dahlbyk committed May 4, 2024
    Configuration menu
    Copy the full SHA
    8043c23 View commit details
    Browse the repository at this point in the history

  13. Build 0.10.0

    @dahlbyk
    dahlbyk committed May 4, 2024
    Configuration menu
    Copy the full SHA
    2f5020d View commit details
    Browse the repository at this point in the history