Fix removing validation + Undebounce

[dahlbyk]

• Fixes Disabling validation #100
  • cc Rescanning dynamic inputs does not detect that they are new #107
• Fixes Initial isFieldValid returns true when field is empty and uses required validator. #108

More than I usually like to change at once, but all interrelated. In particular:

• Fixes some bugs related to removing validation from a field/form
• Removing validation from a field/form now also unwires event handlers
• Validation is now only debounced on input/change; manual validation calls start (and resolve, if none are async) immediately
• validateForm() and validateField() have been changed from returning void to returning Promise<boolean>, resolving with the same value their callback would receive.

[haacked]

I've started reviewing this.

[haacked]

Found a bug during my testing. It's in the review.

[haacked]

I think this is a little confusing (as evidenced by the bug I point out later). As I understand it, this.formInputs is a way of looking up all form inputs for a form. And formInputs is all the inputs for the current form. So we may want to rename this local variable something like currentFormInputs.

And for extra credit, perhaps this.formInputs should be this.formsInputs or this.forms?

[dahlbyk]

For now I've applied consistency in usage/naming (formInputUIDs = this.formInputs[formUID]), which (combined with your "use the variable" suggestion) makes the bug more obvious.

A more precise rename (inputsByFormUID?) might be useful, but there are several similar lookup fields we'd want to update for consistency.

[dahlbyk]

I did push a fix for the bug Phil found, and rebuilt 0.10.0.

[haacked]

Nice work!

Might be nice to include an example of how to clear existing validation messages when you disable validation. But that can happen later.

[lonix1]

WOW! Nice work!

[lonix1]

I'd like to write some docs for the "remove validation" feature. (I'm unfamiliar with the history of the "undebounce" feature, so I'll leave that for another day or another person.)

Comments:

• I think the demo has the button text toggling the wrong way round. One must click the remove button repeatedly to show the expected text. Very minor point, not important, just something I found.

Questions, I want to know whether I understand the new behaviour:

• To remove validation from a form, one uses v.remove(formElement)
• One can readd validation to that form via v.scan(formElement)
• Validation failure classes remain after removal, e.g. input-validation-error. This is by design as the form's original state could have been server-side errors. If the user wants different behaviour he can reset/remove them.
• Is there a way to perform the "full reset" idea from this comment, or should one do that manually (possibly by clicking on the form's "reset" button, if it has one)?
• I'm using document.querySelectorAll('form') or someButton.form to target the form; out of curiosity only (because the library has many cool undocumented features), is it possible to tell which forms the library is currently tracking? UPDATE: a reasonable way is let forms = [...new Set(Array.from(document.querySelectorAll('[data-val]')).map(x => x.form))]; forms.forEach(form => v.remove(form));

Anything else I need to know?

(Sorry for the long list of questions. The new bits are really useful, thanks!)

[haacked]

@lonix1 Great questions! Would you mind opening a new issue with these questions? New questions on a closed PR are easy to overlook. 😄

[lonix1]

Sorry I thought opening a new issue would be spamming your repo. :) I've done so here: #114