-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Europe local language Epic, header local language translation #944
Open
paul-daniel-dempsey
wants to merge
16
commits into
main
Choose a base branch
from
pd-epic-local-langauage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-daniel-dempsey
changed the title
Pd epic local langauage
Europe local language epic, header local language translation
Aug 23, 2023
paul-daniel-dempsey
changed the title
Europe local language epic, header local language translation
Europe local language Epic, header local language translation
Aug 23, 2023
paul-daniel-dempsey
force-pushed
the
pd-epic-local-langauage
branch
from
August 31, 2023 19:26
9e6eb80
to
69bb9d4
Compare
rBangay
previously approved these changes
Sep 1, 2023
Might suggest pinging MT-TX to ensure this implementation wouldn't conflict with existing tests. Typically we'd hardcode an epic test but could double check this approach is suitable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Marketing would like to target users' in specific countries viewing the Epic, altering the Epic copy to be a message in the Country’s regional language.
Countries to target:
Germany,
France,
Netherlands,
Sweden,
Spain,
Italy,
{_Awaiting epic header, paragraphs and highlightedtext _}
On the /epic endpoint if the user is in the EUR test and in the subset of countries adjust response to return hardcoded copy. This way we don’t have to edit the template. We include the reader’s country code in the payload sent to /epic.
All other countries in the Europe Moment Banner test that are not listed above should just have default headline copy defined in the Banner test in the RRCP.
Epic Test : LOCAL-LANGUAGE
Epic Variant: Control
{Awaiting Epic test name, Variant name text}
Epic With Choice Cards {shown below}
How to test (PostMan /Curl)
URL Post (local server) : http://localhost:8082/epic?force=LOCAL-LANGUAGE:CONTROL
URL Post (CODE server) : https://contributions.code.dev-guardianapis.com/epic?force=LOCAL-LANGUAGE:CONTROL
Body (JSON) :
{"tracking":{"ophanPageId":"llqtdrguy4wz77yp8mde","platformId":"GUARDIAN_WEB","clientName":"dcr","referrerUrl":"https://m.code.dev-theguardian.com/world/2020/may/08/commemorating-ve-day-during-coronavirus-lockdown-somehow-the-quiet-made-it-louder"},"targeting":{"contentType":"Article","sectionId":"world","shouldHideReaderRevenue":false,"isMinuteArticle":false,"isPaidContent":false,"tags":[{"id":"world/ve-day","type":"Keyword","title":"VE Day"},{"id":"uk/uk","type":"Keyword","title":"UK news"},{"id":"uk/monarchy","type":"Keyword","title":"Monarchy"},{"id":"world/coronavirus-outbreak","type":"Keyword","title":"Coronavirus"},{"id":"world/secondworldwar","type":"Keyword","title":"Second world war"},{"id":"politics/politics","type":"Keyword","title":"Politics"},{"id":"campaign/callout/callout-coronavirus","type":"Campaign","title":"callout-coronavirus"},{"id":"type/article","type":"Type","title":"Article"},{"id":"tone/comment","type":"Tone","title":"Comment"},{"id":"profile/jonathanfreedland","type":"Contributor","title":"Jonathan Freedland","twitterHandle":"Freedland","bylineImageUrl":"https://i.guim.co.uk/img/static/sys-images/Guardian/Pix/pictures/2014/4/17/1397749333991/JonathanFreedland.jpg?width=300&quality=85&auto=format&fit=max&s=177de144f667fcc9ecb6a44dd82d857b","bylineLargeImageUrl":"https://i.guim.co.uk/img/uploads/2017/10/06/Jonathan-Freedland,-L.png?width=300&quality=85&auto=format&fit=max&s=90f61dcd11d7b649b02bd894f077a689"},{"id":"publication/theguardian","type":"Publication","title":"The Guardian"},{"id":"theguardian/mainsection","type":"NewspaperBook","title":"Main section"},{"id":"theguardian/mainsection/topstories","type":"NewspaperBookSection","title":"Top stories"},{"id":"tracking/commissioningdesk/uk-opinion","type":"Tracking","title":"UK Opinion"}],"showSupportMessaging":false,"isRecurringContributor":false,"lastOneOffContributionDate":1688131783336,"epicViewLog":[{"date":1686648620068,"testId":"EMOJI_TEST"}],"weeklyArticleHistory":[{"week":19590,"count":1,"tags":{"world/coronavirus-outbreak":1,"politics/politics":1}},{"week":19583,"count":1,"tags":{"world/coronavirus-outbreak":1,"politics/politics":1}},{"week":19555,"count":1,"tags":{"world/coronavirus-outbreak":1,"politics/politics":1}}],"hasOptedOutOfArticleCount":false,"mvtId":0,"countryCode":"DE","modulesVersion":"v3","url":"https://m.code.dev-theguardian.com/world/2020/may/08/commemorating-ve-day-during-coronavirus-lockdown-somehow-the-quiet-made-it-louder","isSignedIn":false}}
[Trello] https://trello.com/c/TcAHyBEE/1496-europe-moment-epic-copy-in-local-language