localLanguage object undefined cases and tests

guardian · Aug 31, 2023 · 9e6eb80 · 9e6eb80
1 parent 954f037
commit 9e6eb80
Show file tree

Hide file tree

Showing 3 changed files with 50 additions and 6 deletions.
diff --git a/packages/server/src/api/epicRouter.ts b/packages/server/src/api/epicRouter.ts
@@ -141,9 +141,9 @@ export const buildEpicRouter = (
 
         const propsVariant = {
             ...variant,
-            heading: localLanguage.epicHeader ?? variant.heading,
-            paragraphs: localLanguage.epicParagraphs ?? variant.paragraphs,
-            highlightedText: localLanguage.epicHighlightedText ?? variant.highlightedText,
+            heading: localLanguage?.epicHeader ?? variant.heading,
+            paragraphs: localLanguage?.epicParagraphs ?? variant.paragraphs,
+            highlightedText: localLanguage?.epicHighlightedText ?? variant.highlightedText,
             tickerSettings,
             showReminderFields,
             choiceCardAmounts: variantAmounts,

diff --git a/packages/shared/src/lib/localLanguage.test.ts b/packages/shared/src/lib/localLanguage.test.ts
@@ -47,6 +47,24 @@ describe('getCountryCodeToLocalLanguage', () => {
                 epicHighlightedText: `Highlight (Dutch)`,
             },
         },
+        {
+            inputCountryCode: 'NL',
+            inputTestName: 'LOCAL-LANGUAGE1',
+            inputVariant: 'CONTROL',
+            output: undefined,
+        },
+        {
+            inputCountryCode: 'NL',
+            inputTestName: 'LOCAL-LANGUAGE',
+            inputVariant: 'CONTROL1',
+            output: undefined,
+        },
+        {
+            inputCountryCode: 'NL',
+            inputTestName: '',
+            inputVariant: '',
+            output: undefined,
+        },
         {
             inputCountryCode: 'SE',
             inputTestName: 'LOCAL-LANGUAGE',
@@ -67,7 +85,13 @@ describe('getCountryCodeToLocalLanguage', () => {
             inputCountryCode: 'GB',
             inputTestName: 'LOCAL-LANGUAGE',
             inputVariant: 'CONTROL',
-            output: {},
+            output: undefined,
+        },
+        {
+            inputCountryCode: 'GB',
+            inputTestName: '',
+            inputVariant: '',
+            output: undefined,
         },
         {
             inputCountryCode: 'US',
@@ -103,6 +127,24 @@ describe('getCountryCodeToLocalLanguage', () => {
                 epicHighlightedText: `Highlight`,
             },
         },
+        {
+            inputCountryCode: '',
+            inputTestName: '',
+            inputVariant: '',
+            output: undefined,
+        },
+        {
+            inputCountryCode: '',
+            inputTestName: '',
+            inputVariant: '',
+            inputDefaultLocalLanguage: {
+                bannerHeader: 'BannerHeaderTest',
+                epicHeader: 'EpicHeaderTest',
+                epicParagraphs: ['1', '2', '3', '4', '5'],
+                epicHighlightedText: `Highlight`,
+            },
+            output: undefined,
+        },
     ];
 
     countries.forEach(

diff --git a/packages/shared/src/lib/localLanguage.ts b/packages/shared/src/lib/localLanguage.ts
@@ -51,10 +51,12 @@ export const countryCodeToVerfiedLocalLanguage = (
     variantName: string,
     countryCode?: string,
     dfltLocalLanguage?: LocalLanguage,
-): LocalLanguage => {
+): LocalLanguage | undefined => {
+    const hasCountryLanguageOrDefault = localLanguages[countryCode] || dfltLocalLanguage;
     if (
         testName === (LocalLanguageEpicTestName || LocalLanguageBannerTestName) &&
-        variantName === (LocalLanguageEpicVariant || LocalLanguageBannerVariant)
+        variantName === (LocalLanguageEpicVariant || LocalLanguageBannerVariant) &&
+        hasCountryLanguageOrDefault
     ) {
         return (
             localLanguages[countryCode] ?? {