This repository has been archived by the owner on Dec 16, 2020. It is now read-only.
Pure Terraform TLS Management #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorinasub17
force-pushed
the
yori-tf-tls-mgmt
branch
from
9e53524 to
51bf0c9
Compare
|
@rileykarson I have rebased the changes and the diff is now correct. |
|
NOTES ON EXAMPLE CHANGES:
|
rileykarson
approved these changes
May 2, 2019
| description = "The name of the service account to use for Tiller." | ||
| } | ||
|
|
||
| variable "tls_subject" { |
There was a problem hiding this comment.
Should we provide defaults like we do in other modules now?
There was a problem hiding this comment.
Good idea. Done.
yorinasub17
force-pushed
the
yori-tf-tls-mgmt
branch
from
7310890 to
0eb84e6
Compare
yorinasub17
force-pushed
the
yori-tf-tls-mgmt
branch
from
3f966fb to
3203b81
Compare
|
UPDATE: Rebased on master to resolve merge conflicts |
autero1
reviewed
May 15, 2019
autero1
approved these changes
May 15, 2019
robmorgan
reviewed
May 15, 2019
| // os.Setenv("SKIP_create_terratest_options", "true") | ||
| // os.Setenv("SKIP_terraform_apply", "true") | ||
| // os.Setenv("SKIP_validate", "true") | ||
| // os.Setenv("SKIP_cleanup", "true") |
There was a problem hiding this comment.
add // os.Setenv("SKIP_validate_upgrade", "true")
robmorgan
reviewed
May 15, 2019
| }) | ||
|
|
||
| test_structure.RunTestStage(t, "validate_upgrade", func() { | ||
| // Make sure the upgrade command mentioned in the docs actually works |
Co-Authored-By: autero1 <[email protected]>
|
Thanks for the review folks! I'm going to merge and release this now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements modules to do TLS management in pure terraform using the
kubernetesandtlsproviders, as an alternative to usingkubergrunt. In this model, the user does not need to installkubergruntat all to use all the features. As a part of this, this updates the root example to use the pure terraform version, while migrating thekubergruntversion to the examples folder.Note that the major drawback of this approach is that the TLS cert information will leak into the Terraform state file.
This is understandably a big PR and a big change. We do NOT have to merge this right away with launch so close.