This repository has been archived by the owner on Dec 16, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
Migrate TLS generation into the k8s-tiller module #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorinasub17
commented
May 3, 2019
modules/k8s-tiller/main.tf
Outdated
EOF | ||
|
||
# TODO: When package-terraform-utilities is available, replace | ||
esc_newl = "\\" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: I already have approval to open package-terraform-utilities
up. I have a PR that does the license change and such, so will update this once that is merged.
UPDATES:
|
NOTE: gruntwork-io/kubergrunt#47 is required for this implementation to work. |
autero1
approved these changes
May 6, 2019
Going to merge this into the feature branch so the entire changeset is one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges into #26
Once I started to use the new version in EKS, it turned into a mess as I had a lot of copy pasting to do, and the
kubergrunt
calls were messy to control. As I copied into both the EKS example AND the reference architecture, I couldn't help but wonder if the TLS generation should just be handled in thek8s-tiller
module. I think it makes sense, given that we force the usage of TLS in there.The downside of this approach is that the
k8s-tiller
implementation is now complex given the conditionals spread across an inner module call, and the kubernetes authentication methods. For example, take a look at the conditional logic used to decide which authentication parameters to pass intokubectl
andkubergrunt
.Nevertheless from a UX perspective, I think this is the right approach.
Note that I opted not to pull in the client granting and waiting for tiller. I think both those features make sense to leave out of the module for better flexibility. E.g you might want to use the provider to generate the Tiller TLS certs, but rely on
kubergrunt
for granting and configuring because you plan on running those outside of terraform.