Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass proper headers to return contributions after github update broke api #8

Merged

Conversation

d3or
Copy link
Contributor

@d3or d3or commented Mar 29, 2024

No description provided.

@d3or
Copy link
Contributor Author

d3or commented Mar 29, 2024

Hi @grubersjoe,

It seems like the API still works if the proper headers are passed, however, the tests seem to be a bit off. I do not have time to work on fixing the issue with the tests.

Thanks

@d3or d3or mentioned this pull request Mar 29, 2024
Some repositories were deleted recently and this should explain the different numbers.
@grubersjoe grubersjoe force-pushed the pass-proper-headers-to-return-contributions branch from 5ac82b1 to 3228400 Compare March 29, 2024 22:25
@grubersjoe
Copy link
Owner

Thanks a lot @d3or, this looks great and fixes the API a lot easier than what I came up with so far :). I've added a few more commits to fix the tests, which are green again. (The numbers were a bit off, because I've deleted some old repositories recently.)

@d3or
Copy link
Contributor Author

d3or commented Mar 29, 2024

No problem, thanks a lot for creating this API! Very helpful

@grubersjoe grubersjoe merged commit 9667427 into grubersjoe:main Mar 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants