-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User not found #7
Comments
Hey. Thanks for reporting this! GitHub seems to have changed how the contribution graph is rendered. Now client-side JavaScript appears to be required. You can test this by disabling JavaScript in your browser (the chart never shows up, but you will only see a spinner forever). Consequently, the contribution data can no longer be scraped by simply parsing the HTML source. So this will make this a lot harder, unfortunately, and I have to think about this. There probably is no way around something like Puppeteer which sounds quite heavy. |
I think I've found a way around Puppeteer so that DOM parsing can still be used. There's an endpoint that prerenders some of the calendar, but it should be all we need: |
Hey @grubersjoe, why not just use graphql? EDIT: managed to implement a custom version of your component |
Oh wow, there's an API now? I'm pretty sure there wasn't when I started the project. In this case of course this is way to go. I'll look into it later. Thanks for the hint! |
I could not find the documentation anywhere, just that post. You can take a look at my crude implementation here Glad that I helped ;) |
Hey @grubersjoe, It's really unfortunate that GitHub changed their rendering strategy. I was actually using GitHub's GraphQL API and I had two major issues with it that ultimately lead me to using your API:
I resorted to using your API because your web-scraping strategy bypasses these two issues. These are just some things to consider as your working on a fix if you're using GraphQL. While something like Puppeteer may be heavy, it could perhaps bring in a tremendous amount of value that is not currently being supported by GraphQL. Hope this helps! |
Hi. PR here that should fix this: #8 |
Deployed latest version, everything should work again. Thanks everyone ❤️! |
@yangavin I think you made two very good points 👍. The rate limit would probably be reached pretty fast. Scraping is fragile but it solves these two issues. |
A regular request to get user's contributions stopped working, getting a response of:
{
"error": "User \"grubersjoe\" not found."
}
The text was updated successfully, but these errors were encountered: