Skip to content

Conversation

@t-bowcock
Copy link
Contributor

Changes

Build label list handledLabelsWithCode in loop to place code.String() in correct place.
Fixes #804

Verification

Tested with grpc server on a personal project.

@t-bowcock
Copy link
Contributor Author

All unit tests passed when running make test locally. Not sure why it has failed here or how to re run the job

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't worry about that test failure, there's no way this is related. Thanks for the fix!

@johanbrandhorst johanbrandhorst merged commit 748e2b2 into grpc-ecosystem:main Oct 31, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Prometheus] grpc_server_handled_total incorrectly registers context labels as grpc_code during pre registration

2 participants