Skip to content

Commit 748e2b2

Browse files
authored
fix metric label initialize (#810)
1 parent af451d0 commit 748e2b2

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

providers/prometheus/server_metrics.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ func (m *ServerMetrics) preRegisterMethod(serviceName string, mInfo *grpc.Method
130130

131131
// Build complete label value arrays
132132
startedLabels := append([]string{methodType, serviceName, methodName}, contextLabels...)
133-
handledLabels := append([]string{methodType, serviceName, methodName}, contextLabels...)
134133
streamLabels := append([]string{methodType, serviceName, methodName}, contextLabels...)
135134

136135
// These are just references (no increments), as just referencing will create the labels but not set values.
@@ -141,7 +140,7 @@ func (m *ServerMetrics) preRegisterMethod(serviceName string, mInfo *grpc.Method
141140
_, _ = m.serverHandledHistogram.GetMetricWithLabelValues(streamLabels...)
142141
}
143142
for _, code := range interceptors.AllCodes {
144-
handledLabelsWithCode := append(handledLabels, code.String())
143+
handledLabelsWithCode := append([]string{methodType, serviceName, methodName, code.String()}, contextLabels...)
145144
_, _ = m.serverHandledCounter.GetMetricWithLabelValues(handledLabelsWithCode...)
146145
}
147146
}

0 commit comments

Comments
 (0)