fix component props from attrs not respecting provided transient props #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary: This PR addressed a bug when transient props(
transientProps()
) is provided/used with attrs(attrs()
), the rendered component props is not respecting provided transient props.Problem: On transient props function body,
shouldForwardProp
, an argument that refers to the provided transientProps, is not passed along as the result of the execution, so the closure in the next execution, that is used to executeattrs
, is lost and cannot capture the already defined transientProps, resulting in incorrect rendered component props, the props is not filtered by transientProps.Solution: Pass along the
transientProps
to the template, so that, it is available when executingattrs