fix component props from attrs not respecting provided transient props

gregberge · Aug 12, 2024 · 3b9823a · 3b9823a
1 parent 1b4e2bf
commit 3b9823a
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/index.test.tsx b/src/index.test.tsx
@@ -279,4 +279,20 @@ describe("twc", () => {
     expect(svg).toBeDefined();
     expect(svg.tagName).toBe("SVG");
   });
+
+  test("component props from attrs should respect provided transient props", () => {
+    type ButtonProps = TwcComponentProps<"button"> & {
+      variant: "primary" | "secondary";
+    };
+    const Button = twc.button
+      .transientProps(["variant"])
+      .attrs<ButtonProps>(({ type = "button", variant }) => {
+        expect(variant).toBe("primary");
+        return { type };
+      })`text-xl`;
+    render(<Button data-testid="button" variant="primary" />);
+
+    const renderedButton = screen.getByTestId("button");
+    expect(renderedButton.getAttribute("variant")).toBeNull();
+  });
 });
diff --git a/src/index.tsx b/src/index.tsx
@@ -171,7 +171,7 @@ export const createTwc = <TCompose extends AbstractCompose = typeof clsx>(
 
       if (attrs === undefined) {
         template.attrs = (attrs: Attributes) => {
-          return createTemplate(attrs);
+          return createTemplate(attrs, shouldForwardProp);
         };
       }