-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bigslice: extract dump package from auto-log
Summary: Extract a `diagnostic/dump` package from bigslice auto-log. This merges work that we paused in D33024 with the recently added auto-log, hopefully leaving us with the best of both worlds: - Create a new `diagnostic/dump` package that handles the actual dumping of diagnostics. It has these changes from auto-log: - Expose API for parts of the dump to be registered externally (i.e. anything importing the package can add to the diagnostic dump). - Stop relying on HTTP. Given that we want as much reliability as possible when dumping diagnostics, bypassing HTTP as a layer probably gives us a better shot at it. - Rename some of the files in the dump to be more consistent with route names. - Accommodate use cases that the HTTP endpoints don't handle yet (which we'll fix separately), specifically that we can have multiple `bigmachine.B`s and `bigslice.Session`s in a single process. - Make the dump a gzipped tar archive instead of a zip file (just because that's what was in D33024). - Make the dump filename more informative: include executable name, start time, and duration from start time. - Add a few more diagnostic files: load, CPU, memory, and command-line. - Make auto-log use `diagnostic/dump`. - Expose an endpoint, `/debug/dump`, that allows you to retrieve a diagnostic dump on demand. Test Plan: Add and run unit tests. Run manual tests. Reviewers: pgopal, marius, joshnewman Reviewed By: marius, joshnewman Subscribers: smahadevan Differential Revision: https://phabricator.grailbio.com/D37556 fbshipit-source-id: 736a799
- Loading branch information
Showing
3 changed files
with
193 additions
and
69 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.