ec2machine: do not attempt to use a private dns address (#12)

grailbio · Oct 21, 2019 · 078f177 · 078f177
1 parent af840fd
commit 078f177
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/ec2system/ec2machine.go b/ec2system/ec2machine.go
@@ -611,8 +611,9 @@ func getAddress(instance *ec2.Instance) string {
 	for _, ptr := range []*string{
 		instance.PublicDnsName,
 		instance.PublicIpAddress,
-		instance.PrivateDnsName,
 		instance.PrivateIpAddress,
+		// NOTE: do not return a private DNS name since in it is not guaranteed to
+		//       be resolvable externally.
 	} {
 		if val := aws.StringValue(ptr); len(val) > 0 {
 			return val