pr: Fail when the CI status fails #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainlane
force-pushed
the
iainlane/pr-tests
branch
from
2e77b36 to
2960e9f
Compare
This was referenced Jul 4, 2023
Merged
Merged
iainlane
force-pushed
the
iainlane/pr-tests
branch
from
2960e9f to
51e6764
Compare
iainlane
force-pushed
the
iainlane/pr-add-fail-on-ci-fail
branch
from
a5ab806 to
ffd97d2
Compare
zzehring
approved these changes
Jul 5, 2023
iainlane
force-pushed
the
iainlane/pr-tests
branch
2 times, most recently
from
356feac to
b1c5206
Compare
In this case the PR will probably not be merged, but we can fail waiting for it if its combined status is failed.
iainlane
force-pushed
the
iainlane/pr-add-fail-on-ci-fail
branch
from
ffd97d2 to
9b7f38a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a PR stack:
In this case the PR will probably not be merged, but we can fail waiting
for it if its combined status is failed.
I'm undecided on whether we should unconditionally do this, add a flag, and/or allow passing named checks. In here now I've gone for just doing it unconditionally, maybe we can see how that goes.