Merged
Conversation
This was referenced Jul 4, 2023
Merged
iainlane
force-pushed
the
iainlane/pr-tests
branch
from
2960e9f to
51e6764
Compare
zzehring
approved these changes
Jul 5, 2023
Contributor
zzehring
left a comment
zzehring
left a comment
There was a problem hiding this comment.
LGTM! very small refactor nit, but definitely not needed.
iainlane
force-pushed
the
iainlane/pr-tests
branch
from
51e6764 to
356feac
Compare
Some small refactoring to allow for it, nothing major.
iainlane
force-pushed
the
iainlane/pr-tests
branch
from
356feac to
b1c5206
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of a PR stack:
Some small refactoring to allow for it, nothing major.