Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create direct paging integrations with two default routes (+ migrate existing ones) #5382

Conversation

joeyorlando
Copy link
Contributor

@joeyorlando joeyorlando commented Dec 20, 2024

What this PR does

Related to #5379

Before
Screenshot 2024-12-20 at 11 18 54 AM

After
Screenshot 2024-12-20 at 11 19 46 AM

https://www.loom.com/share/aade8befd7e5414ba358a840f0a6074d

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@joeyorlando joeyorlando added the release:enhancement PR will be added to "Exciting New Features 🎉" section of release notes label Dec 20, 2024
@joeyorlando joeyorlando requested review from a team as code owners December 20, 2024 17:01
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-12-20 at 12 13 25 PM

Copy link
Contributor

@matiasb matiasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeyorlando joeyorlando merged commit 31af852 into jorlando/allow-setting-direct-paging-importance-for-teams Jan 2, 2025
19 of 20 checks passed
@joeyorlando joeyorlando deleted the jorlando/auto-create-direct-paging-integration-routes branch January 2, 2025 16:43
joeyorlando added a commit that referenced this pull request Jan 6, 2025
## Which issue(s) this PR closes

This is a quick db migration follow-up to
#5382. It's mostly just an
enhancement. Basically #5382 had created a new/non-default route for
each Direct Paging integration. However, I overlooked actually setting
the chatops/escalation chain data for this new route:

![Screenshot 2025-01-06 at 3 55
19 PM](https://github.com/user-attachments/assets/6c9e68c3-64b7-47e2-9de6-34edd151b505)

This PR simply updates the recently created non-default direct paging
integration route, such that, to start, direct paging a team has no
escalation/notification difference whether the user doing the direct
paging sets important = True or False. From here, teams can modify these
routes to their needs (ex. setup and assign different escalation chains
for these different routes).

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:enhancement PR will be added to "Exciting New Features 🎉" section of release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants