-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create direct paging integrations with two default routes (+ migrate existing ones) #5382
Merged
joeyorlando
merged 2 commits into
jorlando/allow-setting-direct-paging-importance-for-teams
from
jorlando/auto-create-direct-paging-integration-routes
Jan 2, 2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grate existing ones)
joeyorlando
added
the
release:enhancement
PR will be added to "Exciting New Features 🎉" section of release notes
label
Dec 20, 2024
joeyorlando
temporarily deployed
to
github-pages
December 20, 2024 17:01 — with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 20, 2024 17:01 — with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 20, 2024 17:01 — with
GitHub Actions
Inactive
3 tasks
joeyorlando
commented
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
joeyorlando
temporarily deployed
to
github-pages
December 20, 2024 17:15 — with
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
December 20, 2024 17:15 — with
GitHub Actions
Inactive
joeyorlando
had a problem deploying
to
github-pages
December 20, 2024 17:15 — with
GitHub Actions
Failure
matiasb
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
joeyorlando
merged commit Jan 2, 2025
31af852
into
jorlando/allow-setting-direct-paging-importance-for-teams
19 of 20 checks passed
joeyorlando
deleted the
jorlando/auto-create-direct-paging-integration-routes
branch
January 2, 2025 16:43
3 tasks
joeyorlando
added a commit
that referenced
this pull request
Jan 6, 2025
## Which issue(s) this PR closes This is a quick db migration follow-up to #5382. It's mostly just an enhancement. Basically #5382 had created a new/non-default route for each Direct Paging integration. However, I overlooked actually setting the chatops/escalation chain data for this new route: ![Screenshot 2025-01-06 at 3 55 19 PM](https://github.com/user-attachments/assets/6c9e68c3-64b7-47e2-9de6-34edd151b505) This PR simply updates the recently created non-default direct paging integration route, such that, to start, direct paging a team has no escalation/notification difference whether the user doing the direct paging sets important = True or False. From here, teams can modify these routes to their needs (ex. setup and assign different escalation chains for these different routes). ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Related to #5379
Before
After
https://www.loom.com/share/aade8befd7e5414ba358a840f0a6074d
Checklist
pr:no public docs
PR label added if not required)release:
). These labels dictate how your PR willshow up in the autogenerated release notes.