Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow setting direct paging importance for teams #5379

Merged
merged 12 commits into from
Jan 6, 2025
Merged

feat: allow setting direct paging importance for teams #5379

merged 12 commits into from
Jan 6, 2025
+498 −53

Conversation

joeyorlando
Copy link
Contributor

@joeyorlando joeyorlando commented Dec 19, 2024 •
edited
Loading

Which issue(s) this PR closes

https://www.loom.com/share/e1858db48e8b4fa99014a997af5e3d5e

Closes https://github.com/grafana/irm/issues/322

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@joeyorlando joeyorlando added the release:enhancement PR will be added to "Exciting New Features 🎉" section of release notes label Dec 19, 2024
@joeyorlando joeyorlando requested review from a team as code owners December 19, 2024 16:50
joeyorlando
joeyorlando commented Dec 19, 2024
View reviewed changes
docs/sources/configure/integrations/references/manual/index.md Outdated

### Important escalations

TODO:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be done in a separate PR focused on auto-creating 2 routes w/ templates for Direct Paging integrations.

That PR will be merged into this branch, before merging to dev.

@joeyorlando
mypy fix
eda3728
@joeyorlando
Merge branch 'jorlando/allow-setting-direct-paging-importance-for-tea…
2352c63 
…ms' of github.com:grafana/oncall into jorlando/allow-setting-direct-paging-importance-for-teams
@joeyorlando joeyorlando mentioned this pull request Dec 20, 2024
Merged
3 tasks
@joeyorlando
Copy link
Contributor Author

NOTE: #5382 should be merged into this branch first, before merging this PR into dev

joeyorlando and others added 2 commits December 20, 2024 12:15
@joeyorlando
update test_sync_teams_for_organization test
d624c7f
@joeyorlando
Merge pull request #5382 from grafana/jorlando/auto-create-direct-pag…
31af852 
…ing-integration-routes

feat: create direct paging integrations with two default routes (+ migrate existing ones)
joeyorlando
joeyorlando commented Jan 2, 2025
View reviewed changes
docs/sources/configure/integrations/references/manual/index.md
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was merged/reviewed in #5382

engine/apps/alerts/migrations/0072_upsert_direct_paging_integration_routes.py Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was merged/reviewed in #5382

engine/apps/alerts/models/alert_receive_channel.py Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was merged/reviewed in #5382

engine/apps/alerts/tests/test_alert_receiver_channel.py Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was merged/reviewed in #5382

engine/apps/user_management/tests/test_sync.py Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was merged/reviewed in #5382

vstpme
vstpme approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@vstpme vstpme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/sources/oncall-api-reference/escalation.md Outdated Show resolved Hide resolved
@joeyorlando joeyorlando enabled auto-merge January 6, 2025 15:30
@joeyorlando joeyorlando added this pull request to the merge queue Jan 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2025
@joeyorlando joeyorlando added this pull request to the merge queue Jan 6, 2025
Merged via the queue into dev with commit 152d5f7 Jan 6, 2025
26 checks passed
@joeyorlando joeyorlando deleted the jorlando/allow-setting-direct-paging-importance-for-teams branch January 6, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstpme vstpme vstpme approved these changes

Assignees
No one assigned
Labels
release:enhancement PR will be added to "Exciting New Features 🎉" section of release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeyorlando @vstpme