Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): Chrome folder is shown when no starting URL is provided #388

Merged
merged 3 commits into from
Dec 20, 2024
Merged

fix(windows): Chrome folder is shown when no starting URL is provided #388

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
328527a
fix(windows): Chrome folder is shown when no starting URL is provided
going-confetti Dec 19, 2024
6668a38
cr
going-confetti Dec 20, 2024
38d26e6
trim url
going-confetti Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export const launchBrowser = async (
`--proxy-server=http://localhost:${appSettings.proxy.port}`,
`--ignore-certificate-errors-spki-list=${certificateSPKI}`,
disableChromeOptimizations,
url ?? '',
url ?? 'about:blank',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still able to reproduce the issue on Windows. My guess url is an empty string and doesn't trigger nullish operator fallback, the || operator should do the trick.

You can also verify this on macos: about:blank should open as an empty page, currently it opens to chrome homepage with google search.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth to also to url.trim() to handle the user entering a bunch of spaces.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I didn't even notice this on MacOS 🤦‍♂️

],
onExit: sendBrowserClosedEvent,
})
Expand Down
Loading