fix(windows): Chrome folder is shown when no starting URL is provided #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
going-confetti
requested review from
cristianoventura,
e-fisher and
allansson
and removed request for
a team and
cristianoventura
e-fisher
requested changes
Dec 20, 2024
src/browser.ts
Outdated
| @@ -70,7 +70,7 @@ export const launchBrowser = async ( | |||
| `--proxy-server=http://localhost:${appSettings.proxy.port}`, | |||
| `--ignore-certificate-errors-spki-list=${certificateSPKI}`, | |||
| disableChromeOptimizations, | |||
| url ?? '', | |||
| url ?? 'about:blank', | |||
There was a problem hiding this comment.
I'm still able to reproduce the issue on Windows. My guess url is an empty string and doesn't trigger nullish operator fallback, the || operator should do the trick.
You can also verify this on macos: about:blank should open as an empty page, currently it opens to chrome homepage with google search.
There was a problem hiding this comment.
Might be worth to also to url.trim() to handle the user entering a bunch of spaces.
There was a problem hiding this comment.
You're right, I didn't even notice this on MacOS 🤦♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Windows, if the user doesn't provide a URL before starting a recording, the browser shows the Chrome folder.
How to Test
On a windows machine:
Start recordingwhile leaving theStarting URLblank