feat(CompareView): Implement new Comparison view with Scenes #119

grafakus · 2024-08-09T11:56:02Z

✨ Description

Related issue(s): is blocked by #117

This PR introduces the new comparison view:

As well as the ability to select the same item for baseline and comparison in the "Labels" view:

📖 Summary of the changes

See diff tab for specific comments.

🧪 How to test?

Manually, after checking this PR's branch in local

…a groupByValue

…ew flame graph" action

…items

…ided

github-actions · 2024-08-09T11:57:22Z

Unit test coverage

Lines	Statements	Branches	Functions
	11.12% (464/4170)	8.6% (134/1558)	8.32% (107/1285)

src/pages/ProfilesExplorerView/components/SceneProfilesExplorer/SceneProfilesExplorer.tsx

# Conflicts: # src/pages/ProfilesExplorerView/components/SceneExploreServiceLabels/components/SceneGroupByLabels/components/SceneLabelValuesGrid/components/SceneLabelValuePanel.tsx

src/pages/ProfilesExplorerView/components/SceneProfilesExplorer/ui/ExplorationTypeSelector.tsx

src/pages/ProfilesExplorerView/components/SceneLabelValuesBarGauge.tsx

ifrost · 2024-08-23T07:30:58Z

src/pages/ProfilesExplorerView/components/SceneMainServiceTimeseries.tsx

@@ -25,7 +25,7 @@ export class SceneMainServiceTimeseries extends SceneObjectBase<SceneMainService

  protected _variableDependency = new VariableDependencyConfig(this, {
    variableNames: ['profileMetricId'],
-    onVariableUpdateCompleted: () => {
+    onReferencedVariableValueChanged: () => {


question: Why do need to change it from onVariableUpdateCompleted?

onVariableUpdateCompleted can be called for more reasons than just when the variable value has changed.

Here, if we just want to update the timeseries title to reflect the new profile metric value, we just need onReferencedVariableValueChanged

src/pages/ProfilesExplorerView/components/SceneProfilesExplorer/SceneProfilesExplorer.tsx

...ploreDiffFlameGraph/components/SceneComparePanel/components/SceneTimeRangeWithAnnotations.ts

ifrost · 2024-08-23T08:08:51Z

A few minor UI issues:

Issue	Screenshot
Bottom border of the highlight is cut off
Missing padding at the bottom of comparison graph and label being positioned to high

...neExploreDiffFlameGraph/components/SceneDiffFlameGraph/infrastructure/useFetchDiffProfile.ts

grafakus · 2024-08-23T11:05:09Z

A few minor UI issues:
Bottom border of the highlight is cut off

It's been fixed in fixed in f9791ff#diff-408e010c621ad2b07badfec78e18b0eac9453f9ad586e631f85d5fdc48dae0d7R424

Missing padding at the bottom of comparison graph and label being positioned to high

I can't see the issue, which browser do you use?

ifrost

Great stuff!

grafakus · 2024-08-23T11:36:01Z

A few minor UI issues:
Bottom border of the highlight is cut off

It's been fixed in fixed in f9791ff#diff-408e010c621ad2b07badfec78e18b0eac9453f9ad586e631f85d5fdc48dae0d7R424

Missing padding at the bottom of comparison graph and label being positioned to high

I can't see the issue, which browser do you use?

It's actually an issue with the selector that removes the border from the panel. Fixed.

grafakus added 18 commits August 6, 2024 18:19

feat(Labels): Create new comparison flow

41994a8

Merge branch 'main' into feat/revamp-labels

ebb8505

feat(ComparePanel): Personalized tooltips on radio buttons

162e9d5

fix: GroupByVariable now loads when landing an favs then Labels with …

62f551c

…a groupByValue

fix(SceneExploreServiceLabels): The main timeseries should have a "Vi…

df0b747

…ew flame graph" action

feat(ComparePanel): Remove radio button tooltip when selected

8edeec6

chore(SceneGroupByLabels): Prevent unwanted renderGridItems call

dfd2095

chore: Better comment

cc8c6aa

feat(*): Various improvements

c6236ed

feat(SceneLabelValuesGrid): Add "Hide panels without data" switcher

f364e1c

refactor: Slight change

aeeba87

feat(SceneLabelValuesGrid): Hide no data don't fetch data but render …

309b725

…items

refactor(*): Various fixes and improvements

123205c

fix(SceneLabelValuesGrid): Add missing loading state change

acf4b35

feat(SceneMainServiceTimeseries): Preserve color when an item is prov…

136b3cd

…ided

feat: Comment previous change

08311d5

refactor(*): Better naming and files org

04f9265

feat(*): WiP

d9bf0ee

github-actions bot added the feature label Aug 9, 2024

grafakus added 4 commits August 9, 2024 15:39

feat(*): WiP

6eea745

chore(*): Fix imports

dab2dec

Merge branch 'feat/revamp-labels' into feat/new-scenes-comparison-view

db325a5

refactor(*): Better naming

90d2b8d

grafakus changed the base branch from main to feat/revamp-labels August 9, 2024 13:46

grafakus added 5 commits August 9, 2024 15:55

fix(SceneComparePanel): Fix legend bug

25ff03d

fix: Small fixes

0c655e7

feat: Make selection work

b7d3527

feat(*): Make toggle range selection mode work

4ce83a3

chore(StatsPanel): Small code improvement

d7d7b62

grafakus added 2 commits August 22, 2024 12:02

refactor(syncYAxis): Simplify code

2867c1b

chore: Add missing comments

07d9ad5

grafakus commented Aug 22, 2024

View reviewed changes

src/pages/ProfilesExplorerView/components/SceneProfilesExplorer/SceneProfilesExplorer.tsx Show resolved Hide resolved

grafakus added 4 commits August 22, 2024 12:24

Merge branch 'main' into feat/new-scenes-comparison-view

a271e87

# Conflicts: # src/pages/ProfilesExplorerView/components/SceneExploreServiceLabels/components/SceneGroupByLabels/components/SceneLabelValuesGrid/components/SceneLabelValuePanel.tsx

chore(StatsPanel): minor UI tweaks

d932ed6

fix(SceneLabelValuePanel): Fix after main rebase

35de4c3

fix(CompareActions): Enable toggle on checkbox

ea5b2ff

grafakus marked this pull request as ready for review August 22, 2024 10:47

grafakus added 3 commits August 22, 2024 19:25

fix(*): Small UI fixes

f9791ff

refactor(*): Create SceneDiffFlameGraph

309c6f0

chore: Minor UI tweak

f76037f

ifrost previously approved these changes Aug 23, 2024

View reviewed changes

ifrost reviewed Aug 23, 2024

View reviewed changes

...neExploreDiffFlameGraph/components/SceneDiffFlameGraph/infrastructure/useFetchDiffProfile.ts Outdated Show resolved Hide resolved

grafakus added 5 commits August 23, 2024 11:07

chore(*): Address PR comments #1

0ac31ee

test(EndToEnd): Add smoke test for the new diff view

98113a7

chore(*): Address PR comments #2

63b0732

fix(Diff): Fix incorrect ranges + address PR comments

5470a93

feat(Labels): Add tooltips on compare actions

2b21e14

grafakus dismissed ifrost’s stale review via 2b21e14 August 23, 2024 10:43

chore: Better naming/clarify with comment

c0e6740

grafakus requested a review from ifrost August 23, 2024 11:19

chore(SceneComparePanel): Minor UI fix

0e8ffa8

ifrost approved these changes Aug 23, 2024

View reviewed changes

grafakus merged commit 127d6c3 into main Aug 23, 2024
4 of 5 checks passed

grafakus deleted the feat/new-scenes-comparison-view branch August 23, 2024 11:36

This was referenced Aug 23, 2024

fix(DiffFlameGraph): Fix the "Explain Flame Graph" (AI) feature #129

Merged

feat(*): Remove legacy comparison views code #143

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(CompareView): Implement new Comparison view with Scenes #119

feat(CompareView): Implement new Comparison view with Scenes #119

grafakus commented Aug 9, 2024 •

edited

Loading

github-actions bot commented Aug 9, 2024 •

edited

Loading

ifrost Aug 23, 2024

grafakus Aug 23, 2024 •

edited

Loading

ifrost commented Aug 23, 2024 •

edited

Loading

grafakus commented Aug 23, 2024

ifrost left a comment

grafakus commented Aug 23, 2024

feat(CompareView): Implement new Comparison view with Scenes #119

feat(CompareView): Implement new Comparison view with Scenes #119

Conversation

grafakus commented Aug 9, 2024 • edited Loading

✨ Description

📖 Summary of the changes

🧪 How to test?

github-actions bot commented Aug 9, 2024 • edited Loading

Unit test coverage

ifrost Aug 23, 2024

Choose a reason for hiding this comment

grafakus Aug 23, 2024 • edited Loading

Choose a reason for hiding this comment

ifrost commented Aug 23, 2024 • edited Loading

grafakus commented Aug 23, 2024

ifrost left a comment

Choose a reason for hiding this comment

grafakus commented Aug 23, 2024

grafakus commented Aug 9, 2024 •

edited

Loading

github-actions bot commented Aug 9, 2024 •

edited

Loading

grafakus Aug 23, 2024 •

edited

Loading

ifrost commented Aug 23, 2024 •

edited

Loading