Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line filter: add case sensitive line filter state to local storage #956

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Line filter: add case sensitive line filter state to local storage #956

merged 7 commits into from
Dec 13, 2024
+27 −3

Conversation

gtk-grafana
Copy link
Contributor

@gtk-grafana gtk-grafana commented Dec 12, 2024 •
edited
Loading

Part of: #952

Adds the line filter case sensitivity toggle value to local storage

@gtk-grafana gtk-grafana mentioned this pull request Dec 12, 2024
Open
10 tasks
@gtk-grafana gtk-grafana marked this pull request as ready for review December 12, 2024 16:15
@gtk-grafana gtk-grafana requested a review from a team as a code owner December 12, 2024 16:15
@gtk-grafana gtk-grafana self-assigned this Dec 12, 2024
@gtk-grafana gtk-grafana added the enhancement New feature or request label Dec 12, 2024
@gtk-grafana gtk-grafana added this to the 1.0.5 milestone Dec 12, 2024
@gtk-grafana gtk-grafana mentioned this pull request Dec 12, 2024
Closed
matyax
matyax reviewed Dec 13, 2024
View reviewed changes
src/services/store.ts Outdated Show resolved Hide resolved
@matyax
Copy link
Contributor

matyax commented Dec 13, 2024

Should we make case sensitive the default?

@gtk-grafana gtk-grafana enabled auto-merge (squash) December 13, 2024 14:15
@gtk-grafana gtk-grafana merged commit 04a2bc7 into main Dec 13, 2024
4 checks passed
@gtk-grafana
Copy link
Contributor Author

@matyax

Should we make case sensitive the default?

I created a spot for this discussion: #962

shantanualsi pushed a commit that referenced this pull request Dec 17, 2024
@gtk-grafana @shantanualsi
Line filter: add case sensitive line filter state to local storage (#956
e52ae58 
)

* feat: add case sensitive line filter state to local storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyax matyax matyax approved these changes

Assignees

@gtk-grafana gtk-grafana

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@gtk-grafana @matyax