Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin nox version in requirements.in for devcontainer. #1215

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

gagangupt16
Copy link
Contributor

@gagangupt16 gagangupt16 commented Oct 22, 2024

--require-hashes requires pinned dependency version. Currently, devcontainer is failing to build.

Post Create command will still fail but DevContainer will be built.

Fixes #1214 #1216 🦕

`--require-hashes` requires pinned dependency version.
Currently, devcontainer is failing to build.

Post Create command will still fail but
DevContainer will be built.
@gagangupt16 gagangupt16 requested review from a team as code owners October 22, 2024 05:54
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 22, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Oct 22, 2024
@gagangupt16 gagangupt16 changed the title fix: Pin nox version in requirements.in for devcontainer. fix: pin nox version in requirements.in for devcontainer. Oct 22, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2024
verification

Current command unit tests which require setting
up project. Hence, using a more relaxed but works
in all environment.
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2024
@harshachinta harshachinta merged commit 41604fe into googleapis:main Nov 7, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DevContainer not being built
4 participants