Skip to content

Commit

Permalink
fix: pin nox version in requirements.in for devcontainer. (#1215)
Browse files Browse the repository at this point in the history
* fix: Pin `nox` version in `requirements.in` for devcontainer.

`--require-hashes` requires pinned dependency version.
Currently, devcontainer is failing to build.

Post Create command will still fail but
DevContainer will be built.

* fix: Use nox linting command as DevContainer
verification

Current command unit tests which require setting
up project. Hence, using a more relaxed but works
in all environment.
  • Loading branch information
gagangupt16 authored Nov 7, 2024
1 parent e15e84f commit 41604fe
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/postCreate.sh
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
echo "Post Create Starting"

nox -s unit-3.8
nox -s blacken
2 changes: 1 addition & 1 deletion .devcontainer/requirements.in
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nox>=2022.11.21
nox==2024.10.9
6 changes: 5 additions & 1 deletion .devcontainer/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.9
# This file is autogenerated by pip-compile with Python 3.8
# by the following command:
#
# pip-compile --generate-hashes requirements.in
Expand Down Expand Up @@ -32,6 +32,10 @@ platformdirs==4.3.6 \
--hash=sha256:357fb2acbc885b0419afd3ce3ed34564c13c9b95c89360cd9563f73aa5e2b907 \
--hash=sha256:73e575e1408ab8103900836b97580d5307456908a03e92031bab39e4554cc3fb
# via virtualenv
tomli==2.0.2 \
--hash=sha256:2ebe24485c53d303f690b0ec092806a085f07af5a5aa1464f3931eec36caaa38 \
--hash=sha256:d46d457a85337051c36524bc5349dd91b1877838e2979ac5ced3e710ed8a60ed
# via nox
virtualenv==20.27.1 \
--hash=sha256:142c6be10212543b32c6c45d3d3893dff89112cc588b7d0879ae5a1ec03a47ba \
--hash=sha256:f11f1b8a29525562925f745563bfd48b189450f61fb34c4f9cc79dd5aa32a1f4
Expand Down

0 comments on commit 41604fe

Please sign in to comment.