Skip to content

fix(core): Fix race condition in SyncClient loop init #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anubhav756 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −6
Open

fix(core): Fix race condition in SyncClient loop init #468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/toolbox-core/src/toolbox_core/sync_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@


from asyncio import AbstractEventLoop, new_event_loop, run_coroutine_threadsafe
from threading import Thread
from threading import Lock, Thread
from typing import Any, Awaitable, Callable, Mapping, Optional, Union

from deprecated import deprecated
Expand All @@ -34,6 +34,7 @@ class ToolboxSyncClient:

__loop: Optional[AbstractEventLoop] = None
__thread: Optional[Thread] = None
__lock: Lock = Lock()

def __init__(
self,
Expand All @@ -53,11 +54,13 @@ def __init__(
# Running a loop in a background thread allows us to support async
# methods from non-async environments.
if self.__class__.__loop is None:
loop = new_event_loop()
thread = Thread(target=loop.run_forever, daemon=True)
thread.start()
self.__class__.__thread = thread
self.__class__.__loop = loop
with self.__class__.__lock:
if self.__class__.__loop is None:
loop = new_event_loop()
thread = Thread(target=loop.run_forever, daemon=True)
thread.start()
self.__class__.__thread = thread
self.__class__.__loop = loop

async def create_client():
return ToolboxClient(url, client_headers=client_headers, protocol=protocol)
Expand Down