fix(core): Fix race condition in SyncClient loop init
#468
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a race condition in ToolboxSyncClient where multiple threads could initialize separate event loops, causing aiohttp to raise RuntimeError. This change adds a thread lock to ensure the shared background event loop is initialized exactly once.
3 tasks
kurtisvg
approved these changes
Dec 15, 2025
Contributor
kurtisvg
left a comment
kurtisvg
left a comment
There was a problem hiding this comment.
Somewhat concerned -- how did we hit this race condition? Doesn't the GIL prevent us from having to use a lock unless someone is multi-threading?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition in
ToolboxSyncClientwhere multiple threads could initialize separate event loops, causingaiohttpto raiseRuntimeError.This change adds a thread lock to ensure the shared background event loop is initialized exactly once.
Fixes #428