Skip to content

fix(gax): make FakePagedApi inner classes public to fix compilation error #12776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
diegomarquezp wants to merge 1 commit into from
+2 −2
Closed

fix(gax): make FakePagedApi inner classes public to fix compilation error #12776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...platform-java/gax-java/gax/src/test/java/com/google/api/gax/rpc/testing/FakePagedApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ public ListIntegersPagedResponse apply(ListIntegersPage input) {
}
}

private static class ListIntegersPage
public static class ListIntegersPage
Copy link
Copy Markdown
Contributor

@blakeli0 blakeli0 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should make this change. This class has existed for a while and we didn't run into any issues. I think it is because the build infra messed up somewhere after monorepo migration.

Copy link
Copy Markdown
Contributor Author

@diegomarquezp diegomarquezp Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG, I'll backtrack and find the origin of this problem. Thanks for the quick review.

extends AbstractPage<Integer, List<Integer>, Integer, ListIntegersPage> {

public ListIntegersPage(
Expand All @@ -148,7 +148,7 @@ protected ListIntegersPage createPage(
}
}

private static class ListIntegersSizedPage
public static class ListIntegersSizedPage
extends AbstractFixedSizeCollection<
Integer, List<Integer>, Integer, ListIntegersPage, ListIntegersSizedPage> {

Expand Down
Loading