fix(gax): make FakePagedApi inner classes public to fix compilation error#12776
Closed
diegomarquezp wants to merge 1 commit intomainfrom
Closed
fix(gax): make FakePagedApi inner classes public to fix compilation error#12776diegomarquezp wants to merge 1 commit intomainfrom
diegomarquezp wants to merge 1 commit intomainfrom
Conversation
blakeli0
reviewed
Apr 13, 2026
| @@ -133,7 +133,7 @@ public ListIntegersPagedResponse apply(ListIntegersPage input) { | |||
| } | |||
| } | |||
|
|
|||
| private static class ListIntegersPage | |||
| public static class ListIntegersPage | |||
Contributor
There was a problem hiding this comment.
I don't think we should make this change. This class has existed for a while and we didn't run into any issues. I think it is because the build infra messed up somewhere after monorepo migration.
Contributor
Author
There was a problem hiding this comment.
SG, I'll backtrack and find the origin of this problem. Thanks for the quick review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a compilation error in
PagingTestwhereFakePagedApi.ListIntegersSizedPagewas reported as having private access.In
FakePagedApi.java,ListIntegersSizedPageandListIntegersPagewere declared asprivate static class. However, they were used as type parameters in the public classListIntegersPagedResponse. This exposure of private types via public type parameters caused compilation failures in stricter compiler environments (as seen in the CI failure).Changes
ListIntegersPageandListIntegersSizedPagefromprivatetopublicinFakePagedApi.java.Verification Results
mvn test-compile -pl sdk-platform-java/gax-java/gaxsucceeds.