Skip to content

Fix state share copy to clipboard in insecure context (http) #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix state share copy to clipboard in insecure context (http) #791

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a6e82a
state: support state share copying for insecure (http) context
RussTorres Jun 7, 2025
08c20c1
state_share: updating with setClipboard
RussTorres Jul 29, 2025
62096be
state_share: lint fix
RussTorres Jul 29, 2025
7655d70
state_server: add fail message and fix setClipboard type error
RussTorres Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/datasource/state_share.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { ReadableHttpKvStore } from "#src/kvstore/http/common.js";
import { joinBaseUrlAndPath } from "#src/kvstore/url.js";
import { StatusMessage } from "#src/status.js";
import { setClipboard } from "#src/util/clipboard.js";
import { RefCounted } from "#src/util/disposable.js";
import { bigintToStringJsonReplacer } from "#src/util/json.js";
import type { Viewer } from "#src/viewer.js";
Expand Down Expand Up @@ -104,12 +105,14 @@ export class StateShare extends RefCounted {
stateUrlProtcol.length,
);
const protocol = new URL(selectedStateServer).protocol;
const link = `${window.location.origin}/#!${protocol}${stateUrlWithoutProtocol}`;
navigator.clipboard.writeText(link).then(() => {
StatusMessage.showTemporaryMessage(
"Share link copied to clipboard",
);
});
const link = `${window.location.origin}${window.location.pathname}#!${protocol}${stateUrlWithoutProtocol}`;

const result = setClipboard(link);
StatusMessage.showTemporaryMessage(
result
? "Share link copied to clipboard"
: "Failed to copy share link to clipboard",
);
})
.catch(() => {
StatusMessage.showTemporaryMessage(
Expand Down
Loading