Fix state share copy to clipboard in insecure context (http) #791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the "Share" button to post to a state server on an http deployment on most browsers will send the correct request, but quietly fail copying the link to the clipboard because the navigator requires a secure context.
In this commit I introduce a function that replicates the original behavior in the secure context, while providing a workaround when the original method would fail. I also modify the returned link to include the pathname, which I believe was leading to incompatible copied links when being serving on a subpath.
It's not uncommon to want to stand up http versions of neuroglancer to talk to custom state servers or view local http data sources -- I think this makes deployment easier for those cases and hopefully eliminates some confusion -- let me know what you think.
Thanks!
Russel