Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup for new data entry points #3036

Merged
merged 3 commits into from
Feb 6, 2025

Revert changes to ComposeExt

2d32ba4
Select commit
Loading
Failed to load commit list.
Merged

Minor cleanup for new data entry points #3036

Revert changes to ComposeExt
2d32ba4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 6, 2025 in 0s

62.97% (-0.02%) compared to 06f4dd1

View this Pull Request on Codecov

62.97% (-0.02%) compared to 06f4dd1

Details

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 62.97%. Comparing base (06f4dd1) to head (2d32ba4).

Files with missing lines Patch % Lines
...und/ui/home/mapcontainer/jobs/JobMapComposables.kt 25.00% 4 Missing and 2 partials ⚠️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3036      +/-   ##
============================================
- Coverage     62.99%   62.97%   -0.02%     
+ Complexity     1289     1287       -2     
============================================
  Files           273      273              
  Lines          6731     6723       -8     
  Branches        935      933       -2     
============================================
- Hits           4240     4234       -6     
  Misses         1872     1872              
+ Partials        619      617       -2     
Files with missing lines Coverage Δ
.../java/com/google/android/ground/util/ComposeExt.kt 37.50% <ø> (+4.16%) ⬆️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 17.26% <0.00%> (-0.13%) ⬇️
...und/ui/home/mapcontainer/jobs/JobMapComposables.kt 14.62% <25.00%> (-2.20%) ⬇️