Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup for new data entry points #3036

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

shobhitagarwal1612
Copy link
Member

Performs a minor refactor on #2892 to further remove non-composable logic out of the composable class.

This is a pure refactor and doesn't change the behavior. Verified by running the app locally.

@sufyanAbbasi PTAL?

@auto-assign auto-assign bot requested a review from scolsen February 5, 2025 17:53
@shobhitagarwal1612 shobhitagarwal1612 requested review from sufyanAbbasi and scolsen and removed request for scolsen February 5, 2025 17:53
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 62.97%. Comparing base (06f4dd1) to head (2d32ba4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...und/ui/home/mapcontainer/jobs/JobMapComposables.kt 25.00% 4 Missing and 2 partials ⚠️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3036      +/-   ##
============================================
- Coverage     62.99%   62.97%   -0.02%     
+ Complexity     1289     1287       -2     
============================================
  Files           273      273              
  Lines          6731     6723       -8     
  Branches        935      933       -2     
============================================
- Hits           4240     4234       -6     
  Misses         1872     1872              
+ Partials        619      617       -2     
Files with missing lines Coverage Δ
.../java/com/google/android/ground/util/ComposeExt.kt 37.50% <ø> (+4.16%) ⬆️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 17.26% <0.00%> (-0.13%) ⬇️
...und/ui/home/mapcontainer/jobs/JobMapComposables.kt 14.62% <25.00%> (-2.20%) ⬇️

@shobhitagarwal1612 shobhitagarwal1612 merged commit 102e87d into master Feb 6, 2025
5 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the ashobhit/cleanup-jobmap-composable branch February 6, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants