Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submission count to card data #3037

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Feb 6, 2025

Follow up to #3036

Further simplifies the JobMapComposables by replacing async function call to fetch submission count by adding it to card data. We no longer need to evaluate it on-the-fly as there is only 1 card rendered at a time.

@anandwana001 @sufyanAbbasi PTAL?

@auto-assign auto-assign bot requested a review from anandwana001 February 6, 2025 13:11
@shobhitagarwal1612 shobhitagarwal1612 changed the title Ashobhit/cleanup jobmap composable Add submission count to card data Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 63.14%. Comparing base (102e87d) to head (8f32f83).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 33.33% 1 Missing and 1 partial ⚠️
...me/mapcontainer/HomeScreenMapContainerViewModel.kt 60.00% 0 Missing and 2 partials ⚠️
...und/ui/home/mapcontainer/jobs/JobMapComposables.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3037      +/-   ##
============================================
+ Coverage     62.97%   63.14%   +0.16%     
- Complexity     1287     1291       +4     
============================================
  Files           273      273              
  Lines          6723     6724       +1     
  Branches        933      933              
============================================
+ Hits           4234     4246      +12     
+ Misses         1872     1861      -11     
  Partials        617      617              
Files with missing lines Coverage Δ
.../mapcontainer/jobs/DataCollectionEntryPointData.kt 100.00% <100.00%> (ø)
...und/ui/home/mapcontainer/jobs/JobMapComposables.kt 15.56% <50.00%> (+0.94%) ⬆️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 17.39% <33.33%> (+0.12%) ⬆️
...me/mapcontainer/HomeScreenMapContainerViewModel.kt 54.43% <60.00%> (+2.48%) ⬆️

... and 2 files with indirect coverage changes

@shobhitagarwal1612 shobhitagarwal1612 merged commit 648c8bc into master Feb 7, 2025
5 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the ashobhit/cleanup-jobmap-composable branch February 7, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants