Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add point/polygon] Prompt user whether to add point, draw perimeter, or capture location as allowed by organizer #2469

Open
gino-m opened this issue May 13, 2024 · 13 comments · May be fixed by #2715
Assignees
Labels
type: fr Request for new feature
Milestone

Comments

@gino-m
Copy link
Collaborator

gino-m commented May 13, 2024

@rawbzz @vittorino FYI

@rawbzz
Copy link

rawbzz commented May 13, 2024

Screenshot 2024-05-13 at 11 53 38 AM

@jcqli
Copy link
Contributor

jcqli commented Jun 28, 2024

@shobhitagarwal1612 Are you able to take one this issue?

@shobhitagarwal1612
Copy link
Member

I have a couple of tasks already ongoing. We can take this one up once the proto migration is done.

@gino-m gino-m added the type: fr Request for new feature label Jul 30, 2024
@gino-m gino-m changed the title [Geometry task] Prompt user to add point or draw perimeter when both allowed by organizer [Add point/polygon] Prompt user to add point or draw perimeter when both allowed by organizer Aug 6, 2024
@gino-m gino-m changed the title [Add point/polygon] Prompt user to add point or draw perimeter when both allowed by organizer [Add point/polygon] Prompt user whether to add point, draw perimeter, or capture locatin when both allowed by organizer Sep 4, 2024
@gino-m gino-m changed the title [Add point/polygon] Prompt user whether to add point, draw perimeter, or capture locatin when both allowed by organizer [Add point/polygon] Prompt user whether to add point, draw perimeter, or capture location when both allowed by organizer Sep 4, 2024
@gino-m gino-m changed the title [Add point/polygon] Prompt user whether to add point, draw perimeter, or capture location when both allowed by organizer [Add point/polygon] Prompt user whether to add point, draw perimeter, or capture location as allowed by organizer Sep 4, 2024
@gino-m
Copy link
Collaborator Author

gino-m commented Sep 4, 2024

@anandwana001 can you please coordinate with @rfontanarosa, who is working on google/ground-platform#1744?

You only need to show to pictured UI if more than one value is specified in DrawGeometry.allowed_methods.

@anandwana001
Copy link
Collaborator

Screenshot 2024-05-13 at 11 53 38 AM

@gino-m could you please help me with the figma access for this design? earlier password no more working

@kenstershiro
Copy link
Collaborator

@anandwana001 did you get access to the figma? Anything else needed for this one?

@gino-m
Copy link
Collaborator Author

gino-m commented Nov 4, 2024

@anandwana001 did you get access to the figma? Anything else needed for this one?

@anandwana001 Gentle ping!

@anandwana001
Copy link
Collaborator

anandwana001 commented Nov 4, 2024

@anandwana001 did you get access to the figma? Anything else needed for this one?

Sorry for the late response

Yes, got the figma access. Got all doubts cleared now. Thanks.

@gino-m
Copy link
Collaborator Author

gino-m commented Nov 25, 2024

@anandwana001 We spoke. Let's try to implement this first, but eventually start creating tasks dynamically as they're needed rather than at the start of the data collection flow. Related to #2829 and likely other data collection issues. @shobhitagarwal1612 FYI

@gino-m
Copy link
Collaborator Author

gino-m commented Dec 6, 2024

@rawbzz A few edge case questions:

All of this considered, should we be showing this selector directly on the task screen somehow, eg in place of the map?

@amegantz Can we think of a better prompt than "How will you map this site?" Note we already show "Map a new site" above, so we could just remove the title all together and just show the buttons where the map is currently?

@anandwana001 anandwana001 moved this from In Progress to Todo in Ground Dec 17, 2024
@rawbzz
Copy link

rawbzz commented Dec 17, 2024

Image

@gino-m
Copy link
Collaborator Author

gino-m commented Dec 18, 2024

@rawbzz Looks great, thank you! Added a few variants to the Figma for your input when you have a sec 🙏

@gino-m
Copy link
Collaborator Author

gino-m commented Dec 18, 2024

@rawbzz, thanks for your feedback on Figma. @anandwana001 Latest tweaked designs:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fr Request for new feature
Projects
Status: Todo
6 participants