Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Create/edit survey] Allow data collectors to optionally choose between draw point or polygon tasks #1744

Open
gino-m opened this issue Apr 17, 2024 · 16 comments
Assignees
Labels
type: fr Request for new feature web Angular implementation of Web UI
Milestone

Comments

@gino-m
Copy link
Collaborator

gino-m commented Apr 17, 2024

When doing EUDR reporting, for smaller plots farmers are only required to report a point. Organizers should have the option of punting the decision of geometry type to the data collector. To make this work, we could “Drop a pin” and “Draw or walk a perimeter” into a single task, with two names depending on context:

  • “Map a new site” for “Add LOI tasks”
  • “Annotate site on map” for other “advanced” geometry tasks

In both cases, the survey organizer must specify one or more “Allow data collectors to:” options:

  • “Drop a pin”
  • “Draw or walk perimeter”

If the survey organizer chose >1 geometry of these options, collectors will be prompted to choose which they want to do (e.g., in modal with pin and polygon icons).

@vittorino @amegantz for designs.

Blocked by google/ground-android#2469

@gino-m gino-m added type: fr Request for new feature web Angular implementation of Web UI labels Apr 17, 2024
@gino-m gino-m added this to the Beta release (18-Jul-24) milestone Apr 17, 2024
@jcqli jcqli added the ux needed Product input from PM/UX needed label May 10, 2024
@amegantz
Copy link
Contributor

amegantz commented May 16, 2024

Obsolete design redacted.

@gino-m
Copy link
Collaborator Author

gino-m commented May 17, 2024

@vittorino I think we'd either want the dropdown or the chips (possible with checkboxes to indicate state. Can you update with the final version?

@amegantz For consistency with other field labels (eg 'Instructions") it should probably be in heading voice, eg "Allowed mapping actions" or simiar.

@amegantz
Copy link
Contributor

I think "Mapping actions" works for the heading. Updated the Figma

@vittorino
Copy link

vittorino commented May 29, 2024

Here is the updated mock:

Obsolete design redacted.

@gino-m
Copy link
Collaborator Author

gino-m commented May 30, 2024

@amegantz I think adding "Allowed" makes it clearer that the user has a choice, not that they need to perform all the actions specified there. If it becomes too long, we can drop "Mapping" since it should be clear from context.

@amegantz
Copy link
Contributor

image

@gino-m
Copy link
Collaborator Author

gino-m commented Jul 30, 2024

@lecrabe Punting this to GA release since there's a workaround for smaller plots (draw a small polygon)

@gino-m
Copy link
Collaborator Author

gino-m commented Aug 22, 2024

As per conversation today with @jo-spek, we should also allow users to select "Capture location" as a geometry task to use when adding new sites. Please cmiiw.

@gino-m gino-m changed the title Allow data collectors to optionally choose between draw point or polygon tasks [Create/edit survey] Allow data collectors to optionally choose between draw point or polygon tasks Sep 4, 2024
@gino-m
Copy link
Collaborator Author

gino-m commented Sep 4, 2024

@rfontanarosa Please coordinate with @anandwana001 on google/ground-android#2469.

The DrawGeometry proto already has allowed_methods which can be used for this purpose. For this FR I would leave out @jo-spek's request to allow adding a LOI using the device location for now. Users can work around this by adding a Capture Location task manually to the job.

I suggest @anandwana001 does google/ground-android#2469 before implementing this on web.

@jcqli jcqli moved this to In Progress in Ground Sep 11, 2024
@gino-m
Copy link
Collaborator Author

gino-m commented Sep 18, 2024

@rfontanarosa and I spoke. Suggestions:

  • Let's punt on "Annotate site" for now, focus on "Map a new site"
  • The new site task will be added in the last position like when adding other tasks
  • Update the "free form data collection" label for consistency
  • We can delete the old commented out Add Drop Pin and Walk perimeter code
  • Let's also avoid adding "Capture location" for adding a new site for now (see previous comment)

@vittorino @amegantz What text should appear in the dropdown when multiple actions are selected?

@vittorino
Copy link

We have 2 options: 1) display all values separated by a comma and truncated or 2) display just multiple
I'm a little more inclined towards the second option, but fine with either one

@gino-m
Copy link
Collaborator Author

gino-m commented Sep 18, 2024

We have 2 options: 1) display all values separated by a comma and truncated or 2) display just multiple I'm a little more inclined towards the second option, but fine with either one

Let's go with Multiple, since it scaled better to other languages and avoids truncation.

@jcqli jcqli added the for pm/ux review Product decision needed label Oct 23, 2024
@jcqli
Copy link

jcqli commented Oct 23, 2024

Adding product label to discuss behavior between "Tasks" and "Sites". Toggling free form data collection in "Sites" also adds a "Map a new site" task, is this correct?

@gino-m
Copy link
Collaborator Author

gino-m commented Oct 29, 2024

@rfontanarosa Can we close this?

@gino-m
Copy link
Collaborator Author

gino-m commented Oct 29, 2024

As per conversation today with @jo-spek, we should also allow users to select "Capture location" as a geometry task to use when adding new sites. Please cmiiw.

+100 from @n-clinton

@kenstershiro kenstershiro removed the for pm/ux review Product decision needed label Nov 8, 2024
@gino-m
Copy link
Collaborator Author

gino-m commented Nov 20, 2024

@rfontanarosa Needs to hide/show "Map a site" button depending on whether task is already present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fr Request for new feature web Angular implementation of Web UI
Projects
Status: In Progress
Development

No branches or pull requests

6 participants