Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data collection] Prompt user to select "Drop pin" or "Draw/walk perimeter" when organizers allow it #2715

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

anandwana001
Copy link
Collaborator

@anandwana001 anandwana001 commented Sep 6, 2024

Fixes #2469

@... PTAL?

Screenshot 2024-09-25 at 3 40 44 PM

Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anandwana001 Is this ready for review? Please update the PR description to something more descriptive - "Prompt user to do what?"

Please also provide a video or screenshot once ready.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 38 lines in your changes missing coverage. Please review.

Project coverage is 60.23%. Comparing base (4b19860) to head (2372ba3).

Files with missing lines Patch % Lines
...acollection/tasks/draw/SelectGeometryTaskDialog.kt 0.00% 37 Missing ⚠️
...ersistence/remote/firebase/schema/TaskConverter.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2715      +/-   ##
============================================
- Coverage     60.58%   60.23%   -0.36%     
  Complexity     1162     1162              
============================================
  Files           265      266       +1     
  Lines          6221     6261      +40     
  Branches        878      892      +14     
============================================
+ Hits           3769     3771       +2     
- Misses         1950     1987      +37     
- Partials        502      503       +1     
Files with missing lines Coverage Δ
.../java/com/google/android/ground/model/task/Task.kt 100.00% <100.00%> (ø)
...n/java/com/google/android/ground/ui/theme/Color.kt 100.00% <100.00%> (ø)
...ersistence/remote/firebase/schema/TaskConverter.kt 76.31% <0.00%> (-2.07%) ⬇️
...acollection/tasks/draw/SelectGeometryTaskDialog.kt 0.00% <0.00%> (ø)

@gino-m gino-m changed the title Prompt user Dialog UI [Data collection] Prompt user to select "Drop pin" or "Draw/walk perimeter" when organizers allow it Sep 25, 2024
@gino-m
Copy link
Collaborator

gino-m commented Nov 20, 2024

Hi @anandwana001 What is the status of this PR? Has it been abandoned?

@gino-m
Copy link
Collaborator

gino-m commented Dec 3, 2024

@anandwana001 I see this is allocated for the next Iteration which starts tomorrow, leaving this open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants