Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAVE_SYMBOLIZE not defined when HAVE_LINK_H is #1085

Closed
wants to merge 1 commit into from
Closed

HAVE_SYMBOLIZE not defined when HAVE_LINK_H is #1085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/symbolize.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
#ifndef GLOG_NO_SYMBOLIZE_DETECTION
# ifndef HAVE_SYMBOLIZE
// defined by gcc
# if defined(HAVE_ELF_H) || defined(HAVE_SYS_EXEC_ELF_H)
# if defined(HAVE_ELF_H) || defined(HAVE_SYS_EXEC_ELF_H) || defined(HAVE_LINK_H)
# define HAVE_SYMBOLIZE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this additional check? In CMake builds this define is not necessary. Thus modifications should be limited to Bazel files only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for letting me know this. i agree this would probably introduce undesirable side effects.

In the recent version of glog, HAVE_SYMBOLIZE is not "derived" anymore on linux platform with bazel, unlike previous versions. (i am referring to the one we were using from jan-02-2024)

what's your suggestion getting around with that? just hardcode -DHAVE_SYMBOLIZE in linux_only_copts inside glog.bzl? If so, do you think if anybody else needs this (Im fine (not) sending the patch)

thnx

# elif defined(GLOG_OS_MACOSX) && defined(HAVE_DLADDR)
// Use dladdr to symbolize.
Expand Down
Loading