HAVE_SYMBOLIZE not defined when HAVE_LINK_H is

[wzheng21]

Fixing issue #1084 . We are trying to bump glog up to latest version using bazel in our project.

In glog.bzl, there's HAVE_LINK_H defined. However, in symbolize.h, it doesn't lead
to defining HAVE_SYMBOLIZE, resulting in the error

warning: Symbolize functionality is not available for target platform: stack dump will contain empty frames. [-W#pragma-messages]
#  pragma message( \
          ^
1 warning generated.

[sergiud]

Thanks for the PR.

What you are seeing is not an error but a warning. Please also make sure to modify Bazel files only if the CMake build is not affected to avoid side effects.

[sergiud]

Why do you need this additional check? In CMake builds this define is not necessary. Thus modifications should be limited to Bazel files only.

[wzheng21]

thanks for letting me know this. i agree this would probably introduce undesirable side effects.

In the recent version of glog, HAVE_SYMBOLIZE is not "derived" anymore on linux platform with bazel, unlike previous versions. (i am referring to the one we were using from jan-02-2024)

what's your suggestion getting around with that? just hardcode -DHAVE_SYMBOLIZE in linux_only_copts inside glog.bzl? If so, do you think if anybody else needs this (Im fine (not) sending the patch)

thnx

[wzheng21]

Thanks for the PR.

What you are seeing is not an error but a warning. Please also make sure to modify Bazel files only if the CMake build is not affected to avoid side effects.

That makes sense. Sorry it's a warning. Actually we declared things like InstallSymbolizeCallback in our implementation, then we actually get linking error with the new version of glog. (which makes sense since there's no HAVE_SYMBOLIZE anymore, so the function definition is never compiled into the library)

[jms13]

Alternative solution with "bazel only changes": add -DHAVE_SYMBOLIZE to bazel/glog.bzl in linux_only_copts.

[sergiud]

Fixed by #1116.