Skip to content

Swarming: Avoids mounting volume #5213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IvanBM18 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Swarming: Avoids mounting volume #5213

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0015431
Refactor docker mount check for swarming support
IvanBM18 Mar 20, 2026
aad4d85
Simplifies truthy check for mount conditional
IvanBM18 Mar 23, 2026
ebc380c
Merge branch 'master' into feature/swarming/docker-mount
IvanBM18 Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions docker/base/setup_common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,22 @@ then
export PREEMPTIBLE=True
fi

is_truthy() {
[[ "$1" =~ ^([Tt]rue|1)$ ]]
}

# Make sure mounted volume doesn't have noexec,nosuid,nodev
# Running this in k8s environment will cause mounting errors
if [[ -z "$IS_K8S_ENV" ]]
then
# Running this in k8s or swarming environment will cause mounting errors
should_mount() {
# Skip if running in Kubernetes or as a Swarming Job
if is_truthy "$IS_K8S_ENV" || is_truthy "$SWARMING_BOT"; then
return 1
fi

return 0
}

if should_mount; then
mount /mnt/scratch0 -o remount,exec,suid,dev
fi

Expand Down
Loading