Swarming: Avoids mounting volume

[IvanBM18]

Overview

Swarming, as well as K8S has issues when trying to mounting this volume to the container.

mount /mnt/scratch0 -o remount,exec,suid,dev

So we added a validation to not mount when we are either in K8S or in swarming.

Note: Uses SWARMING_BOT env var as its the one we already use in the swarming request

Tests performed

I created a custom bash script to test this:

should_mount() {
  # Skip if running in Kubernetes
  if [[ -n "$IS_K8S_ENV" ]]; then
    return 1
  fi

  # Skip if running as a Swarming Job
  if [[ "$SWARMING_BOT" == "True" ]] || [[ "$SWARMING_BOT" == "1" ]] || [[ "$SWARMING_BOT" == "true" ]]; then
    return 1
  fi

  return 0
}

test_mount() {
  unset IS_K8S_ENV SWARMING_BOT
  [[ "$1" != "unset" ]] && export IS_K8S_ENV=$1
  [[ "$2" != "unset" ]] && export SWARMING_BOT=$2
  printf "IS_K8S_ENV=%-5s | SWARMING_BOT=%-5s  =>" "$1" "$2"
  if should_mount; then echo " [MOUNT EXECUTED]"; else echo " [MOUNT SKIPPED]"; fi
}

Against multiple inputs:

test_mount "unset" "unset"
test_mount "1"     "unset"
test_mount "unset" "True"
test_mount "unset" "1"
test_mount "unset" "false"

And got this results:

=== DRY RUN OUTPUT USING should_mount ===
IS_K8S_ENV=unset | SWARMING_BOT=unset  => [MOUNT EXECUTED]
IS_K8S_ENV=1     | SWARMING_BOT=unset  => [MOUNT SKIPPED]
IS_K8S_ENV=unset | SWARMING_BOT=True   => [MOUNT SKIPPED]
IS_K8S_ENV=unset | SWARMING_BOT=1      => [MOUNT SKIPPED]
IS_K8S_ENV=unset | SWARMING_BOT=false  => [MOUNT EXECUTED]